Fix login speeds. #6

Closed
opened 2020-11-26 16:53:23 +00:00 by Cutie · 3 comments
Cutie commented 2020-11-26 16:53:23 +00:00 (Migrated from zxq.co)

Original pull request patch:

From 5d008e028457469042bac0e29fab2fa79cb817b4 Mon Sep 17 00:00:00 2001
From: Cutie <pandahble@gmail.com>
Date: Sun, 15 Apr 2018 12:21:14 +0200
Subject: [PATCH 1/2] Update 'inc/helpers/Schiavo.php'

---
 inc/helpers/Schiavo.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/inc/helpers/Schiavo.php b/inc/helpers/Schiavo.php
index 496a40a..9ac215c 100644
--- a/inc/helpers/Schiavo.php
+++ b/inc/helpers/Schiavo.php
@@ -19,5 +19,6 @@ class Schiavo {
 // I don't remember. And don't wanna test to figure it out. So fuck it.
 function __schiavoCall($c, $message) {
 	global $schiavoConfig;
-	return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message));
+  // no point having this here, it slows down login.
+//	return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message));
 }
-- 
2.20.1


From 58ae97095682641bd9263b69d7e9fdc8dd756f61 Mon Sep 17 00:00:00 2001
From: Cutie <pandahble@gmail.com>
Date: Sun, 15 Apr 2018 18:35:51 +0200
Subject: [PATCH 2/2] Update 'inc/helpers/Schiavo.php'

---
 inc/helpers/Schiavo.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/helpers/Schiavo.php b/inc/helpers/Schiavo.php
index 9ac215c..8c7fab9 100644
--- a/inc/helpers/Schiavo.php
+++ b/inc/helpers/Schiavo.php
@@ -19,6 +19,6 @@ class Schiavo {
 // I don't remember. And don't wanna test to figure it out. So fuck it.
 function __schiavoCall($c, $message) {
 	global $schiavoConfig;
-  // no point having this here, it slows down login.
+  // no point having this here, it slows down login if ur not ripple lol.
 //	return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message));
 }
-- 
2.20.1


_Original pull request patch:_ ``` From 5d008e028457469042bac0e29fab2fa79cb817b4 Mon Sep 17 00:00:00 2001 From: Cutie <pandahble@gmail.com> Date: Sun, 15 Apr 2018 12:21:14 +0200 Subject: [PATCH 1/2] Update 'inc/helpers/Schiavo.php' --- inc/helpers/Schiavo.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inc/helpers/Schiavo.php b/inc/helpers/Schiavo.php index 496a40a..9ac215c 100644 --- a/inc/helpers/Schiavo.php +++ b/inc/helpers/Schiavo.php @@ -19,5 +19,6 @@ class Schiavo { // I don't remember. And don't wanna test to figure it out. So fuck it. function __schiavoCall($c, $message) { global $schiavoConfig; - return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message)); + // no point having this here, it slows down login. +// return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message)); } -- 2.20.1 From 58ae97095682641bd9263b69d7e9fdc8dd756f61 Mon Sep 17 00:00:00 2001 From: Cutie <pandahble@gmail.com> Date: Sun, 15 Apr 2018 18:35:51 +0200 Subject: [PATCH 2/2] Update 'inc/helpers/Schiavo.php' --- inc/helpers/Schiavo.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/helpers/Schiavo.php b/inc/helpers/Schiavo.php index 9ac215c..8c7fab9 100644 --- a/inc/helpers/Schiavo.php +++ b/inc/helpers/Schiavo.php @@ -19,6 +19,6 @@ class Schiavo { // I don't remember. And don't wanna test to figure it out. So fuck it. function __schiavoCall($c, $message) { global $schiavoConfig; - // no point having this here, it slows down login. + // no point having this here, it slows down login if ur not ripple lol. // return file_get_contents($schiavoConfig["url"] . $c . "?message=" . urlencode("**old-frontend** " . $message)); } -- 2.20.1 ```
howl commented 2018-04-15 19:41:27 +00:00 (Migrated from zxq.co)

Needed for us. Since the code that we push to production comes directly from this repository, we want to keep Schiavo, so we're not adding this.

Ripple servers which seek to add this may do the following:

cd /path/to/old-frontend
curl https://zxq.co/ripple/old-frontend/pulls/6.diff | git apply
Needed for us. Since the code that we push to production comes directly from this repository, we want to keep Schiavo, so we're not adding this. Ripple servers which seek to add this may do the following: ```sh cd /path/to/old-frontend curl https://zxq.co/ripple/old-frontend/pulls/6.diff | git apply ```
Cutie commented 2020-11-26 16:53:24 +00:00 (Migrated from zxq.co)

not needed

might as well help out other ripple clones though

not needed might as well help out other ripple clones though
howl (Migrated from zxq.co) closed this issue 2020-11-26 16:53:26 +00:00
Cutie commented 2020-11-26 16:53:27 +00:00 (Migrated from zxq.co)

I understand, I wasn't sure since it seemed like an unneeded function

I understand, I wasn't sure since it seemed like an unneeded function
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ripple/old-frontend#6
No description provided.